Add optional encoding parameter to load and dump functions #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ser to pass whatever encoding to use.
|
After several hours of struggling with my machine with a GIT Bash problem, I present the final PR including the |
|
PS: Apologies for the number of failed or cancelled PRs. Several of them were not correct or had late commits due to the problem with my GIT Bash that I mentioned. |
|
@bobfang1992 Awaiting review. Everything should now be in order. |
bobfang1992
approved these changes
Jan 2, 2024
|
Thanks, will merge if all CI passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optional
encodingparameter has been added to thedumpandloadfunctions to provide more flexibility in specifying encoding, rather than always using the system default.